Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACA-1934] Fix search facet fields translation #791

Merged
merged 1 commit into from
Nov 8, 2018
Merged

[ACA-1934] Fix search facet fields translation #791

merged 1 commit into from
Nov 8, 2018

Conversation

suzanadirla
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: https://issues.alfresco.com/jira/browse/ACA-1934

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov-io
Copy link

codecov-io commented Nov 8, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (development@1e31363). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #791   +/-   ##
==============================================
  Coverage               ?   53.01%           
==============================================
  Files                  ?      108           
  Lines                  ?     3003           
  Branches               ?      596           
==============================================
  Hits                   ?     1592           
  Misses                 ?     1328           
  Partials               ?       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e31363...5f1452b. Read the comment docs.

@DenysVuika DenysVuika merged commit 9313b64 into development Nov 8, 2018
@DenysVuika DenysVuika deleted the sdirla-fix-facet-translation branch November 8, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenysVuika DenysVuika DenysVuika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suzanadirla @codecov-io @DenysVuika